Calculate length of texture data during serialization instead of writing a set value & Update ImportGMS2FontData #1048
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I should also check if the value is written for games that use PNG |
|
Download the artifacts for this pull request here: GUI:
CLI: |
|
Uh, won't this not work on pre-2022.3 games? |
|
Hmm, I haven't checked |
|
Added 2022.3 checks, should be correct now
Also we still need to check this |
Miepee
reviewed
Oct 19, 2022
UndertaleModTool/Scripts/Community Scripts/ImportGMS2FontData.csx
Outdated
Show resolved
Hide resolved
UndertaleModTool/Scripts/Community Scripts/ImportGMS2FontData.csx
Outdated
Show resolved
Hide resolved
UndertaleModTool/Scripts/Community Scripts/ImportGMS2FontData.csx
Outdated
Show resolved
Hide resolved
UndertaleModTool/Scripts/Community Scripts/ImportGMS2FontData.csx
Outdated
Show resolved
Hide resolved
Addresses some review suggestions and addes new stuff UNTESTED
Dobby233Liu
commented
Oct 21, 2022
|
What is the status of this pull request? |
…into Dobby233Liu-untextureblocksize-1
VladiStep
requested changes
Jan 28, 2023
UndertaleModTool/Scripts/Community Scripts/ImportGMS2FontData.csx
Outdated
Show resolved
Hide resolved
UndertaleModTool/Scripts/Community Scripts/ImportGMS2FontData.csx
Outdated
Show resolved
Hide resolved
Co-authored-by: VladiStep <vlad2001.21@mail.ru>
VladiStep
approved these changes
Feb 23, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1042